>>> On 25.05.18 at 14:03, <wei.l...@citrix.com> wrote: > On Fri, May 25, 2018 at 05:50:12AM -0600, Jan Beulich wrote: >> >>> On 24.05.18 at 18:05, <wei.l...@citrix.com> wrote: >> > This is a step towards consolidating relevant data structures and >> > defines to one location. >> >> Sort of contrary to what the patch does - it converts one instance of the >> structure to two of them. > > But isn't this test harness an exception to how things are normally > done? I don't think x86 insn emulator is as standalone as other > components.
FAOD: I don't really mind the movement. I do think, though, that the description doesn't match what the patch does. > I never understood why cpuid_leaf was put into x86_emulate.h in the > first place. I tried to convert it to use cpuid.h but that opened an > even bigger can of worms. I guess that's the reason you're looking for. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
