On 29/06/2023 1:17 pm, Alejandro Vallejo wrote: > Currently libxl and the x86-emulator tests carry their own versions. Factor > those out into the common macros header so every library can make use of > it. This is required so the following patch can add this macro to a header > used both in Xen and tools/libs. > > No functional change. > > Signed-off-by: Alejandro Vallejo <alejandro.vall...@cloud.com>
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>, although ... > --- > tools/include/xen-tools/common-macros.h | 3 +++ > tools/libs/light/libxl_internal.h | 2 -- > tools/tests/x86_emulator/x86-emulate.h | 3 --- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/include/xen-tools/common-macros.h > b/tools/include/xen-tools/common-macros.h > index 168691be0e..6d7de1bc0a 100644 > --- a/tools/include/xen-tools/common-macros.h > +++ b/tools/include/xen-tools/common-macros.h > @@ -84,4 +84,7 @@ > (type *)((char *)mptr__ - offsetof(type, member)); \ > }) > > +#define __AC(X,Y) (X##Y) > +#define _AC(X,Y) __AC(X,Y) ... I'll take the opportunity to do style fixes here. ~Andrew
