Hi Stewart,

I haven't yet fully reviewed the code. However, I have one question...

On 07/06/2023 04:02, Stewart Hildebrand wrote:
From: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com>

+static inline int iommu_add_dt_pci_sideband_ids(struct pci_dev *pdev)
+{
+    return 0;
+}
  #endif /* HAS_DEVICE_TREE */
+static inline int iommu_add_pci_sideband_ids(struct pci_dev *pdev)
+{
+    int ret = 0;

Shouldn't this return NO_IOMMU when booting on ACPI platform?

+#ifdef CONFIG_ACPI
+    if ( acpi_disabled )
+#endif
+        ret = iommu_add_dt_pci_sideband_ids(pdev);
+    return ret;
+}
+
  struct page_info;
/*

Cheers,

--
Julien Grall

Reply via email to