> On 14 Jun 2023, at 08:41, Peter Hoyes <peter.ho...@arm.com> wrote: > > From: Peter Hoyes <peter.ho...@arm.com> > > Add -e argument to xl console and pass to new escape_character argument > of libxl_console_exec. > > In libxl_console_exec, there are currently two call sites to execl, > which uses varargs, in order to support optionally passing > 'start-notify-fd' to the console client. In order to support passing > the 'escape' argument optionally too, refactor to instead have a single > call site to execv, which has the same behavior but takes an array of > arguments. > > If -e is not specified, --escape is not passed to the console client and > the existing value (^]) is used as a default. > > Issue-Id: SCM-4958 > Signed-off-by: Peter Hoyes <peter.ho...@arm.com> > Change-Id: I80ffbb7fecc63e023ec1c7f1e4ad7979ccf8da44
Hi Peter, Here in Xen-devel the patches should not have Issue-Id and Change-Id, they can be stripped on commit if the maintainer is willing to do so, otherwise you’ll need to send a v2 with the tags removed. To me the code looks good, still need a maintainer review though. Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
