> On 14 Jun 2023, at 08:41, Peter Hoyes <peter.ho...@arm.com> wrote: > > From: Peter Hoyes <peter.ho...@arm.com> > > Dom0 may be accessed via telnet, meaning the default escape character > (which is the same as telnet's) cannot be directly used to exit the > console. It would be helpful to make the escape character customizable > in such use cases. > > Add --escape argument to console tool for this purpose. > > Create parse_escape_character static function to convert a character > string (which may include a '^' modifier) into an ANSI integer. > > Add argument to getopt options, parse escape character and pass value > to console_loop. > > If --escape is not specified, it falls back to the existing behavior > using DEFAULT_ESCAPE_SEQUENCE. > > Issue-Id: SCM-4958 > Signed-off-by: Peter Hoyes <peter.ho...@arm.com> > Change-Id: I3795e654b382e78144d8210f303e3ebccec457ed
Hi Peter, Here in Xen-devel the patches should not have Issue-Id and Change-Id, they can be stripped on commit if the maintainer is willing to do so, otherwise you’ll need to send a v2 with the tags removed. To me the code looks good, still need a maintainer review though. Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
