On 02.06.2023 02:48, Vikram Garhwal wrote:
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -126,6 +126,47 @@ int iommu_release_dt_devices(struct domain *d)
> return 0;
> }
>
> +int iommu_remove_dt_device(struct dt_device_node *np)
> +{
> + const struct iommu_ops *ops = iommu_get_ops();
> + struct device *dev = dt_to_dev(np);
> + int rc;
> +
> + if ( !ops )
> + return -EOPNOTSUPP;
> +
> + spin_lock(&dtdevs_lock);
> +
> + if ( iommu_dt_device_is_assigned_locked(np) )
> + {
> + rc = -EBUSY;
> + goto fail;
> + }
> +
> + /*
> + * The driver which supports generic IOMMU DT bindings must have this
> + * callback implemented.
> + */
> + if ( !ops->remove_device )
> + {
> + rc = -EOPNOTSUPP;
> + goto fail;
> + }
> +
> + /*
> + * Remove master device from the IOMMU if latter is present and
> available.
> + * The driver is responsible for removing is_protected flag.
> + */
> + rc = ops->remove_device(0, dev);
> +
> + if ( !rc )
> + iommu_fwspec_free(dev);
> +
> +fail:
> + spin_unlock(&dtdevs_lock);
> + return rc;
Same remark regarding label indentation - please address throughout the
series.
Jan
