On 23.05.2023 18:38, Anthony PERARD wrote: > In xen/, it isn't necessary to include Config.mk in every Makefile in > subdirectories as nearly all necessary variables should be calculated > in xen/Makefile. But some Makefile make use of the macro $(cc-option,) > that is only available in Config.mk. > > Extract $(cc-option,) from Config.mk so we can use it without > including Config.mk and thus without having to recalculate some CFLAGS > which would be ignored. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
When I saw the title and in particular the new file's name which is already mentioned there, I did expect something entirely different, perhaps related to the testing of Xen. May I suggest e.g. compiler-probing.mk or maybe even simply compiler.mk? (I'm also uncertain about "compiler", tbh - I could e.g. see Kbuild.include's as-option-add to also be useful outside of xen/, and hence at some point wanting moving to some common file.) > --- a/Config.mk > +++ b/Config.mk > @@ -18,6 +18,7 @@ realpath = $(wildcard $(foreach file,$(1),$(shell cd -P > $(dir $(file)) && echo " > or = $(if $(strip $(1)),$(1),$(if $(strip $(2)),$(2),$(if $(strip > $(3)),$(3),$(if $(strip $(4)),$(4))))) > > -include $(XEN_ROOT)/.config > +include $(XEN_ROOT)/config/compiler-testing.mk Possibly being one of the few users of the top-level .config, I wonder about the ordering of these includes. This isn't to say that I consider wrong the order in which you have it now, but I could see the opposite order as potentially useful, too. Jan
