> On 23 May 2023, at 17:38, Anthony PERARD <anthony.per...@citrix.com> wrote:
> 
> The variable $(CFLAGS) is too often set in the environment,
> especially when building a package for a distribution. Often, those
> CFLAGS are intended to be use to build user spaces binaries, not a

NIT: s/use/used/

But I’m not a native speaker so I might be wrong on this

> kernel. This mean packager needs to takes extra steps to build Xen by
> overriding the CFLAGS provided by the package build environment.
> 
> With this patch, we avoid using the variable $(CFLAGS). Also, the
> hypervisor's build system have complete control over which CFLAGS are
> used.
> 
> No change intended to XEN_CFLAGS used, beside some flags which may be
> in a different order on the command line.
> 
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
> ---
> 
> Notes:
>    There's still $(EXTRA_CFLAGS_XEN_CORE) which allows to add more CFLAGS
>    if someone building Xen needs to add more CFLAGS to the hypervisor
>    build.
> 

Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
Tested-by: Luca Fancellu <luca.fance...@arm.com>



Reply via email to