On 23.05.2023 18:38, Anthony PERARD wrote: > but still show a log entry for syncconfig. We have to use kecho > instead of $(cmd,) to avoid issue with prompt from kconfig.
Reading this description I was looking for uses of $(cmd ...) that you replace. I think this wants wording differently, e.g. "We have to use kecho, not $(cmd,), to ..." > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -382,6 +382,7 @@ $(KCONFIG_CONFIG): tools_fixdep > # This exploits the 'multi-target pattern rule' trick. > # The syncconfig should be executed only once to make all the targets. > include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG) > + $(Q)$(kecho) " SYNC $@" > $(Q)$(MAKE) $(build)=tools/kconfig syncconfig The latter of the Linux commits you reference also extends the comment, to keep people from trying to switch to using $(cmd ...). I think we should follow suit. Jan
