> On 23 May 2023, at 17:38, Anthony PERARD <anthony.per...@citrix.com> wrote: > > CFLAGS is just from Config.mk, instead use the flags used to build > Xen. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > --- > > Notes: > I don't know if CFLAGS is even useful there, just --version without the > flags might produce the same result. > > xen/build.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/build.mk b/xen/build.mk > index e2a78aa806..d468bb6e26 100644 > --- a/xen/build.mk > +++ b/xen/build.mk > @@ -23,7 +23,7 @@ define cmd_compile.h > -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \ > -e 's/@@domain@@/$(XEN_DOMAIN)/g' \ > -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \ > - -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g' \ > + -e 's!@@compiler@@!$(shell $(CC) $(XEN_CFLAGS) --version 2>&1 | head > -1)!g' \ > -e 's/@@version@@/$(XEN_VERSION)/g' \ > -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \ > -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \ > -- > Anthony PERARD > >
Yes I think Andrew is right, so I guess $(XEN_CFLAGS) can be dropped? Reviewed-by: Luca Fancellu <luca.fance...@arm.com> Tested-by: Luca Fancellu <luca.fance...@arm.com> I’ve tested this patch with and without the $(XEN_CFLAGS), so if you drop it you can retain my r-by if you want.
