Hi Michal, > -----Original Message----- > Subject: [PATCH 3/3] xen/arm: vpl011: Do not try to handle TX FIFO status > when backend in Xen > > From vpl011_rx_char_xen(), we call vpl011_data_avail() that handles both > RX and TX state. Because we are passing 0 as out_fifo_level and > SBSA_UART_FIFO_SIZE as out_size, we end up calling a function > vpl011_update_tx_fifo_status() which performs TXI bit handling > depending on the FIFO trigger level. This does not make sense when backend > is in Xen, as we maintain a single TX state where data can always be > written and as such there is no TX FIFO handling. Furthermore, this > function assumes that the backend is in domain by making use of struct > xencons_interface unconditionally. Fix it by calling this function only > when backend is in domain. Also add an assert for sanity. > > Signed-off-by: Michal Orzel <michal.or...@amd.com>
I've tested the patch by manually running the XTP on FVP_Base, and this patch works fine. So: Tested-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry
