On 23.03.2023 11:44, Anthony PERARD wrote:
> On Mon, Mar 06, 2023 at 08:21:38AM +0100, Juergen Gross wrote:
>> --- a/tools/include/xen-tools/common-macros.h
>> +++ b/tools/include/xen-tools/common-macros.h
>> @@ -76,4 +76,8 @@
>> #define __must_check __attribute__((__warn_unused_result__))
>> #endif
>>
>> +#define container_of(ptr, type, member) ({ \
>> + typeof( ((type *)0)->member ) *__mptr = (ptr); \
>
> I think identifier starting with two '_' are supposed to be reserved.
> Would you be ok to have just one? (So "_mptr")
Except that single-underscore prefixed names are also kind of reserved
(for file-scope symbols). Hence why I'm generally suggesting / asking
for trailing underscores to be used.
Jan
