On 06.03.23 08:52, Jan Beulich wrote:
On 06.03.2023 08:21, Juergen Gross wrote:In order to better reflect the contents of the header and to make it more appropriate to use it for different runtime environments like programs, libraries, and firmware, rename the libs.h include file to common-macros.h. Additionally add a comment pointing out the need to be self-contained.Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> # tools/python/xen/lowlevel/xc/xc.cJust as a general remark: I think it would be nice to strive to keep such scope restriction identifiers short as possible without becoming ambiguous. With this ...--- tools/console/daemon/io.c | 2 +- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 2 +- .../include/xen-tools/{libs.h => common-macros.h} | 15 ++++++++++++--- tools/libs/call/buffer.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_sr_common.c | 2 +- tools/libs/light/libxl_internal.h | 2 +- tools/libs/light/libxl_psr.c | 2 +- tools/libs/stat/xenstat_linux.c | 2 +- tools/misc/xen-access.c | 2 +- tools/misc/xen-cpuid.c | 2 +- tools/misc/xen-diag.c | 2 +- tools/misc/xen-hptool.c | 2 +- tools/misc/xen-livepatch.c | 2 +- tools/misc/xen-mfndump.c | 2 +- tools/misc/xenpm.c | 2 +- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- tools/tests/cpu-policy/test-cpu-policy.c | 2 +- tools/tests/paging-mempool/test-paging-mempool.c | 2 +- tools/tests/resource/test-resource.c | 2 +- tools/tests/tsx/test-tsx.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/x86_emulator/x86-emulate.h | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/xenstore/utils.h | 2 +- tools/xentrace/analyze.h | 2 +- tools/xl/xl_cmdtable.c | 2 +- xen/lib/x86/private.h | 2 +- 39 files changed, 50 insertions(+), 41 deletions(-) rename tools/include/xen-tools/{libs.h => common-macros.h} (82%)... diffstat, tools/python/ would be sufficient here imo. (As noted earlier, I consider the marker unnecessary here, just like Christian's isn't scope restricted to tools/ocaml/. While I accept that views may differ here, I think it would be helpful if within a patch optional scope restrictions were all present or all absent; ones truly restricting scope are different of course.)
Hmm, right. In case I need to resend I'll drop the restriction. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
