On 10.01.2023 20:16, Oleksii wrote: > Sorry for breaking into the conversation.
That's perfectly fine; no need to be sorry. > On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: >> Arm maintainers, >> >> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/init.h >>> @@ -0,0 +1,12 @@ >>> +#ifndef _XEN_ASM_INIT_H >>> +#define _XEN_ASM_INIT_H >>> + >>> +#endif /* _XEN_ASM_INIT_H */ >> >> instead of having RISC-V introduce an empty stub matching what x86 >> has, > Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic > early_printk and smoke test implementation) of Andrew: > https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4...@citrix.com/#t > > I agree with his point regarding the usage of __has_include() to not > produce empty headers stubs for RISCV and for future architectures too. Sure, but as he said, that requires settling on a new toolchain baseline, which is something that we've failed to come to any results for, for a considerable number of years. Plus if we could get rid of this (then optional) arch header altogether, it would imo be even better. Jan
