Hello Jan, Sorry for breaking into the conversation.
On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: > Arm maintainers, > > On 10.01.2023 16:17, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/init.h > > @@ -0,0 +1,12 @@ > > +#ifndef _XEN_ASM_INIT_H > > +#define _XEN_ASM_INIT_H > > + > > +#endif /* _XEN_ASM_INIT_H */ > > instead of having RISC-V introduce an empty stub matching what x86 > has, Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic early_printk and smoke test implementation) of Andrew: https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4...@citrix.com/#t I agree with his point regarding the usage of __has_include() to not produce empty headers stubs for RISCV and for future architectures too. > If maintainers are OK I can start to use __has_include() in the > correspondent <xen/*.h> files.what would it take to empty Arm's as > well, allowing both present ones to > go away and no new one to be introduced? The only thing you have in > there > is struct init_info, which doesn't feel like it's properly placed in > this > header (x86 has such stuff in setup.h) ... > > Jan ~Oleksii
