Hi Julien, > -----Original Message----- > Subject: Re: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables > > Hi Henry, > > >> Subject: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables > >> > >> From: Julien Grall <jgr...@amazon.com> > >> > >> At the moment, on Arm64, every pCPU are sharing the same page-tables. > > > > Nit: s/every pCPU are/ every pCPU is/ > > I will fix it.
Thank you. > > >> +bool init_domheap_mappings(unsigned int cpu); > > > > I wonder if we can make this function "__init" as IIRC this function is only > > used at Xen boot time, but since the original init_domheap_mappings() > > is not "__init" anyway so this is not a strong argument. > > While this is not yet supported on Xen on Arm, CPUs can be > onlined/offlined at runtime. So you want to keep init_domheap_mappings() > around. This is a very good point. I agree the pCPU online/offline is affected by the "__init" so leaving the function without the "__init" like what we are doing now is a good idea. > > We could consider to provide a new attribute that will be match __init > if hotplug is supported otherwirse it would be a NOP. But I don't think > this is related to this series (most of the function used for bringup > are not in __init). Agreed. > > >> +static inline bool init_domheap_mappings(unsigned int cpu) > > > > (and also here) > > > > Either you agree with above "__init" comment or not: > > Reviewed-by: Henry Wang <henry.w...@arm.com> > > Thanks! No problem. To avoid confusion, my reviewed-by tag still holds. Kind regards, Henry > > Cheers, > > -- > Julien Grall
