Hi Julien, > -----Original Message----- > Subject: [PATCH 20/22] xen/arm64: mm: Use per-pCPU page-tables > > From: Julien Grall <jgr...@amazon.com> > > At the moment, on Arm64, every pCPU are sharing the same page-tables.
Nit: s/every pCPU are/ every pCPU is/ > > /* > diff --git a/xen/arch/arm/include/asm/domain_page.h > b/xen/arch/arm/include/asm/domain_page.h > new file mode 100644 > index 000000000000..e9f52685e2ec > --- /dev/null > +++ b/xen/arch/arm/include/asm/domain_page.h > @@ -0,0 +1,13 @@ > +#ifndef __ASM_ARM_DOMAIN_PAGE_H__ > +#define __ASM_ARM_DOMAIN_PAGE_H__ > + > +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE > +bool init_domheap_mappings(unsigned int cpu); I wonder if we can make this function "__init" as IIRC this function is only used at Xen boot time, but since the original init_domheap_mappings() is not "__init" anyway so this is not a strong argument. > +#else > +static inline bool init_domheap_mappings(unsigned int cpu) (and also here) Either you agree with above "__init" comment or not: Reviewed-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry
