Hi Ayan, On 31/10/2022 16:13, Ayan Kumar Halder wrote: > > > Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
I think when adding new code we should be taking the latest spec (which is I.a) as a base + you are lacking the information \wrt page number, table, whatever contains this information within ARM ARM. Apart from that, wouldn't it be easier for those reading the commit to just write e.g.: "Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg as well as the function itself with #ifdef CONFIG_ARM_64." Placing EC code in such statement is not very helpful. ~Michal