Hi Julien, > -----Original Message----- > From: Julien Grall <[email protected]> > Sent: Friday, October 28, 2022 4:56 PM > To: Andre Przywara <[email protected]>; Ayan Kumar Halder > <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Bertrand Marquis > <[email protected]>; Henry Wang <[email protected]> > Subject: [for-4.17] Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state > correctly > > Hi, > > On 27/10/2022 21:53, Andre Przywara wrote: > > On Thu, 27 Oct 2022 20:09:13 +0100 > > Ayan Kumar Halder <[email protected]> wrote: > > > > Hi, > > > >> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current > interrupt > >> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" > >> should > be > >> used to restore the saved interrupt state. > >> > >> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and > property tables") > >> Signed-off-by: Ayan Kumar Halder <[email protected]> > > > > Thanks for fixing this! > > > > Reviewed-by: Andre Przywara <[email protected]> > > Acked-by: Julien Grall <[email protected]> > > Henry, this is fixing a bug in the ITS. The feature is at the moment > experiement and the code is not used by other subystem, so technically > not necessary for 4.17. But if you still accept any bug fix (I know we > are close to the release), then I would like to request to include. It > should be risk free.
Yeah, of course. Release-acked-by: Henry Wang <[email protected]> Kind regards, Henry > > Cheers, > > Cheers, > > -- > Julien Grall
