Hi Ayan, > On 27 Oct 2022, at 20:09, Ayan Kumar Halder <[email protected]> wrote: > > As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt > state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should > be > used to restore the saved interrupt state. > > Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and > property tables") > Signed-off-by: Ayan Kumar Halder <[email protected]> Reviewed-by: Bertrand Marquis <[email protected]>
This is definitely a bug fix candidate for 4.17 !! Cheers Bertrand > --- > xen/arch/arm/vgic-v3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > index d0e265634e..015446be17 100644 > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, > mmio_info_t *info, > write_atomic(&v->arch.vgic.rdist_pendbase, reg); > } > > - spin_unlock_irqrestore(&v->arch.vgic.lock, false); > + spin_unlock_irqrestore(&v->arch.vgic.lock, flags); > > return 1; > } > -- > 2.17.1 >
