Hi Julien, > -----Original Message----- > From: Julien Grall <jul...@xen.org> > Subject: Re: [PATCH v4 3/4] xen/arm: mm: Rename xenheap_* variable to > directmap_* > > Hi Henry, > > On 07/09/2022 15:35, Henry Wang wrote: > > With the static heap setup, keep using xenheap_* in the function > > setup_xenheap_mappings() will make the code confusing to read, > > because we always need to map the full RAM on Arm64. Therefore, > > renaming all "xenheap_*" variables to "directmap_*" to make clear > > the area is used to access the RAM easily. > > You are also renaming a function. So I think it should be clarified in > the commit message.
Oops, thanks for the careful review. > > With that: > > Acked-by: Julien Grall <jgr...@amazon.com> Thanks, I will take this tag with above fixed in v5. Kind regards, Henry > > Cheers, > > -- > Julien Grall
