Hi Julien,
> -----Original Message-----
> From: Julien Grall <jul...@xen.org>
> > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells
> > +
> > + Specify the number of cells used for the address and size of the
> > + "xen,static-heap" property under "chosen".
>
> Logging here just because it is easier to keep track of open questions
> :). For the future, I would suggest to list them after --- so they don't
> get lost.
>
> We need to agree on the naming scheme before this gets committed.
I think we are agreed on #address-cells and #size-cells. So I will send
a v5 with these changed.
>
> > diff --git a/xen/arch/arm/include/asm/setup.h
> b/xen/arch/arm/include/asm/setup.h
> > index 5815ccf8c5..31610ccd65 100644
> > --- a/xen/arch/arm/include/asm/setup.h
> > +++ b/xen/arch/arm/include/asm/setup.h
> > @@ -22,11 +22,31 @@ typedef enum {
> > BOOTMOD_UNKNOWN
> > } bootmodule_kind;
> >
> > +enum membank_type {
> > + /*
> > + * The MEMBANK_DEFAULT type refers to either reserved memory for
> the
> > + * device/firmware (when the bank is in 'reserved_mem') or any RAM
> (when
> > + * the bank is in 'mem'.
>
> Typo: Missing ')'
>
> This can be updated on commit if we decide to keep the current naming
> scheme.
Don't bother, I will do it as this patch need a respin anyway..
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
