Re: [PATCH v7 1/9] xen/arm: introduce static shared memory

[Julien Grall]

On 07/09/2022 02:51, Penny Zheng wrote:
Hi Julien

Hi Penny,


-----Original Message-----
From: Julien Grall <jul...@xen.org>
Sent: Wednesday, September 7, 2022 2:01 AM
To: Penny Zheng <penny.zh...@arm.com>; xen-devel@lists.xenproject.org
Cc: Wei Chen <wei.c...@arm.com>; Stefano Stabellini
<sstabell...@kernel.org>; Bertrand Marquis <bertrand.marq...@arm.com>;
Volodymyr Babchuk <volodymyr_babc...@epam.com>; Henry Wang
<henry.w...@arm.com>
Subject: Re: [PATCH v7 1/9] xen/arm: introduce static shared memory

Hi Penny,

On 06/09/2022 09:59, Penny Zheng wrote:
   static int __init early_scan_node(const void *fdt,
                                     int node, const char *name, int depth,
                                     u32 address_cells, u32 size_cells,
@@ -386,6 +549,8 @@ static int __init early_scan_node(const void *fdt,
           process_chosen_node(fdt, node, name, address_cells, size_cells);
       else if ( depth == 2 && device_tree_node_compatible(fdt, node,
"xen,domain") )
           rc = process_domain_node(fdt, node, name, address_cells,
size_cells);
+    else if ( depth <= 3 && device_tree_node_compatible(fdt, node,
"xen,domain-shared-memory-v1") )
+        rc = process_shm_node(fdt, node, address_cells, size_cells);

       if ( rc < 0 )
           printk("fdt: node `%s': parsing failed\n", name); diff --git
a/xen/arch/arm/include/asm/setup.h
b/xen/arch/arm/include/asm/setup.h
index 5815ccf8c5..995eee1d09 100644
--- a/xen/arch/arm/include/asm/setup.h
+++ b/xen/arch/arm/include/asm/setup.h
@@ -23,10 +23,17 @@ typedef enum {
   }  bootmodule_kind;


+/* Indicates the maximum number of characters(\0 included) for shm_id
+*/ #define MAX_SHM_ID_LENGTH 16
+
   struct membank {
       paddr_t start;
       paddr_t size;
       bool xen_domain; /* whether the memory bank is bound to a Xen
domain. */
+#ifdef CONFIG_STATIC_SHM
+    char shm_id[MAX_SHM_ID_LENGTH];
+    unsigned int nr_shm_borrowers;
+#endif

I forgot to mention that this will clash with Henry's series [1]. As both series
are meant for 4.17, please coordinate to decide which series should be
merged first (this is to avoid last minute clash on Friday).


I'll push v8 ASAP when henry's commits get committed~~~~

I would suggest to rebase on top of Henry's series now and resend it 
(you can mention in the cover letter). This will enable the committers 
to merge your series right after and reduce the risk that your series 
miss the deadline (we may only commit Henry's series on Friday morning 
UK time).

Cheers,

--
Julien Grall