On 04.08.2022 17:04, Jane Malalane wrote: > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Jane Malalane <jane.malal...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: "Roger Pau Monné" <roger....@citrix.com> > CC: Wei Liu <w...@xen.org> > --- > xen/arch/x86/x86_64/entry.S | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > index 26bf2f1941..4ad25d9c90 100644 > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -140,6 +140,15 @@ process_trap: > call create_bounce_frame > jmp test_all_events > > + .pushsection .init.text, "ax", @progbits > + ENTRY(early_page_fault)
Why is this line suddenly not unindented anymore (as labels ought to be)? > + ENDBR64 > + movl $TRAP_page_fault,4(%rsp) As you're moving this code, may I ask that you add blanks after the comma here and ... > + SAVE_ALL > + movq %rsp,%rdi ... here? Then, with Andrew's comments also taken care of, Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
