On 04/08/2022 16:04, Jane Malalane wrote: Commit message wants to read "so it's not a random piece of non .text.entry in the middle of .text.entry" or words to this effect.
> Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Jane Malalane <jane.malal...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: "Roger Pau Monné" <roger....@citrix.com> > CC: Wei Liu <w...@xen.org> > --- > xen/arch/x86/x86_64/entry.S | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > index 26bf2f1941..4ad25d9c90 100644 > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -140,6 +140,15 @@ process_trap: > call create_bounce_frame > jmp test_all_events > > + .pushsection .init.text, "ax", @progbits Given that you've (correctly) dropped the .popsection, this should be a plain .section rather than .pushsection. Both can be fixed on commit. ~Andrew
