On 7/19/22 09:29, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/common/domain-builder/Kconfig >> @@ -0,0 +1,15 @@ >> + >> +menu "Domain Builder Features" >> + >> +config BUILDER_FDT >> + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED >> + select CORE_DEVICE_TREE >> + ---help--- > > Nit: No new ---help--- please anymore.
Ack. >> + Enables the ability to configure the domain builder using a >> + flattened device tree. > > Is this about both Dom0 and DomU? Especially if not, this wants making > explicit. But perhaps even if so it wants saying, for the avoidance of > doubt. The following patches will end with full conversion of both Dom0 and DomU construction to be handled by a core domain construction framework. If a device tree configuration is not present or this Kconfig option is not set, then the domain builder will construct a Dom0 as it does today. Turning this option on enables controlling the domain builder using a device tree configuration, which (eventually) will be able to construct any combination of Dom0, HWDom, CtlDom, DomU, etc. So I can add a qualifier of, 'configure what domains will be constructed at boot by the domain builder using a flattened device tree'. I can even add an explanation that on x86 the FDT must be provided as the first multiboot module. v/r, dps
