On 06.07.2022 23:04, Daniel P. Smith wrote: > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capability > such as hyperlaunch. > > Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com> > Reviewed-by: Christopher Clark <christopher.cl...@starlab.io> > --- > xen/arch/arm/bootfdt.c | 115 +---------------------------- > xen/common/Kconfig | 4 ++ > xen/common/Makefile | 3 +- > xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +------------ > xen/include/xen/fdt.h | 79 ++++++++++++++++++++ > 6 files changed, 218 insertions(+), 164 deletions(-) > create mode 100644 xen/common/fdt.c > create mode 100644 xen/include/xen/fdt.h
I think this wants to be accompanied by an update to ./MAINTAINERS, so maintainership doesn't silently transition to THE REST. I further think that the moved code would want to have style adjusted to match present guidelines - I've noticed a number of u<N> uses which should be uint<N>_t. I didn't look closely to see whether other style violations are also retained in the moved code. Jan
