Hi Oleksandr, > -----Original Message----- > From: Oleksandr Tyshchenko <olekst...@gmail.com> > Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm > > From: Julien Grall <julien.gr...@arm.com> > > This patch introduces helpers to allocate Virtio MMIO params > (IRQ and memory region) and create specific device node in > the Guest device-tree with allocated params. In order to deal > with multiple Virtio devices, reserve corresponding ranges. > For now, we reserve 1MB for memory regions and 10 SPIs. > > As these helpers should be used for every Virtio device attached > to the Guest, call them for Virtio disk(s). > > Please note, with statically allocated Virtio IRQs there is > a risk of a clash with a physical IRQs of passthrough devices. > For the first version, it's fine, but we should consider allocating > the Virtio IRQs automatically. Thankfully, we know in advance which > IRQs will be used for passthrough to be able to choose non-clashed > ones. > > Signed-off-by: Julien Grall <julien.gr...@arm.com> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshche...@epam.com> > Tested-by: Jiamei Xie <jiamei....@arm.com> > Reviewed-by: Henry Wang <henry.w...@arm.com> > --- > @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor > change I made, are you still happy with that?
Sorry for the late response, just checked the code and yes I am happy with keeping my Reviewed-by. Thanks for your effort in rebasing the patch! Kind regards, Henry
