Hi, Sorry for the formatting issues.
On Mon, 18 Apr 2022, 21:41 Stefano Stabellini, <sstabell...@kernel.org> wrote: > > +static uint64_t virtio_mmio_base; > > +static uint32_t virtio_mmio_irq; > > No need for these two variables to be global in this file, they could be > local variables in libxl__arch_domain_prepare_config. It is more than "no need". Libxl can be used by a daemon to handle multiple domains. So we can't use static variable to keep track of local information. Cheers,
