On Tue, Dec 14, 2021 at 09:34:28AM +0000, Oleksii Moisieiev wrote: > This enumeration sets SCI type for the domain. Currently there is > two possible options: either 'none' or 'scmi_smc'. > > 'none' is the default value and it disables SCI support at all. > > 'scmi_smc' enables access to the Firmware from the domains using SCMI > protocol and SMC as transport. > > Signed-off-by: Oleksii Moisieiev <oleksii_moisie...@epam.com> > ---
Thanks for the patch, it looks good too me. But it is kind of weird that the manual describes something that isn't implemented yet. Could you maybe add in the patch description that the feature isn't implemented yet or that the feature is implemented in follow-up patches? Also, about the golang binding thingy, could you add a note after a line of a three dash "---" that let know the committer to regenerate everything that needs re-generating due to change in the *.idl file, just in case? Thanks, -- Anthony PERARD
