Hi Julien, On Wed, Dec 15, 2021 at 09:39:32AM +0000, Julien Grall wrote: > Hi, > > Looking at the rest of the series, this is going to be replaced in patch #2 > with: > > return sci_handle_call(); > > SCMI is not specific to RCAR3. So I would expect the function to be called > from common code. > > If it still needs some platform specific code, then I think it would be best > to introduce rcar3.c at the end of the series. So we don't introduce a dummy > platform and not hook the code in the middle of patch#2 which is meant to be > generic. > > I will have a proper review of the rest of the series in the new year. > > Cheers, > > -- > Julien Grall
That's sound reasonable. My first thought was to move SCM func_id to the different section, such as Arm Architecture Service (see Section 6 of DEN0028D). But I think that SiP service func_id fits best in this case because from guest standpoint all clocks\resets\power-domain ids are SoC implementation specific. I'm going to leave SMC func_id in SiP range, but refactor SIP smc handler, so no RCAR3 specific code will be needed. So there will be no need to introduce rcar3.c in this patch series. What do you think about that? Best regards, Oleksii.
