On 29.09.2021 18:56, Stefano Stabellini wrote: > On Tue, 28 Sep 2021, Rahul Singh wrote: >> On Arm, the initial plan is to only support GICv3 ITS which doesn't >> require us to manage the MSIs because the HW will protect against >> spoofing. Move the code under CONFIG_HAS_PCI_MSI flag to gate the code >> for ARM. >> >> No functional change intended. >> >> Signed-off-by: Rahul Singh <rahul.si...@arm.com> >> Reviewed-by: Daniel P. Smith <dpsm...@apertussolutions.com> > > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>
Acked-by: Jan Beulich <jbeul...@suse.com> Nevertheless I'd like to express that ... >> --- a/xen/drivers/pci/Kconfig >> +++ b/xen/drivers/pci/Kconfig >> @@ -1,3 +1,7 @@ >> >> config HAS_PCI >> bool >> + >> +config HAS_PCI_MSI >> + bool >> + depends on HAS_PCI ... personally I think this should be "select HAS_PCI", and the then redundant one in x86 might then want dropping. Jan