Hi Jan, > On 29 Sep 2021, at 9:24 am, Jan Beulich <jbeul...@suse.com> wrote: > > On 28.09.2021 20:18, Rahul Singh wrote: >> prelink.o: In function `pcie_aer_get_firmware_first’: >> drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse' >> >> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM >> architecture. APEI not supported on ARM yet move the code under >> CONFIG_X86 flag to gate the code for ARM. > > Like iirc Julien has pointed out for another, similarly titled patch, > "solve compilation error" doesn't really seem appropriate here, as > with the tree at this point of the series no such error should be > observable. Unless I'm overlooking something. I wil fix the comment as below:
xen/pci: gate APEI support on ARM APEI not supported on ARM yet move the code under CONFIG_X86 flag to gate the code for ARM. This patch is the preparatory work to enable HAS_PCI on ARM to avoid compilation error on ARM. prelink.o: In function `pcie_aer_get_firmware_first’: drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse' > > I'd like to suggest that when you receive review comments, you apply > them throughout the series. If you follow the approach take in the > other patch ... Ok. I will take care of this in future patch series. Regards, Rahul > >> Signed-off-by: Rahul Singh <rahul.si...@arm.com> >> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > > Acked-by: Jan Beulich <jbeul...@suse.com> > > Jan >
