On Mon, 2021-09-20 at 18:25 +0100, Andrew Cooper wrote: > Four TRC_MEM_* records supply custom structures with tail padding, > leaking > stack rubble into the trace buffer. Three of the records were fine > in 32-bit > builds of Xen, due to the relaxed alignment of 64-bit integers, but > POD_SUPERPAGE_SPLITER was broken right from the outset. > > We could pack the datastructures to remove the padding, but > xentrace_format > has no way of rendering the upper half of a 16-bit field. Instead, > expand all > 16-bit fields to 32-bit. > > For POD_SUPERPAGE_SPLINTER, introduce an order field as it is > relevant > information, and to match DECREASE_RESERVATION, and so it doesn't > require a > __packed attribute to drop tail padding. > > Update xenalyze's structures to match, and introduce xentrace_format > rendering > which was absent previously. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Dario Faggioli <dfaggi...@suse.com>
Thanks and Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
signature.asc
Description: This is a digitally signed message part
