On Tue, 2021-09-21 at 13:03 +0200, Jan Beulich wrote: > On 20.09.2021 19:25, Andrew Cooper wrote: > > > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Like for v1: Largely > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Dario Faggioli <dfaggi...@suse.com>
> One remark: > > > @@ -717,9 +713,6 @@ void __trace_var(u32 event, bool_t cycles, > > unsigned int extra, > > if ( !cpumask_test_cpu(smp_processor_id(), &tb_cpu_mask) ) > > return; > > > > - /* Read tb_init_done /before/ t_bufs. */ > > - smp_rmb(); > > - > > spin_lock_irqsave(&this_cpu(t_lock), flags); > > > > buf = this_cpu(t_bufs); > > I wonder whether the comment wouldn't be helpful to move down here, > in of course a slightly edited form (going from /before/ to /after/). > FWIW, I agree with this (but the R-o-b: stands no matter whether it's done or not). Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
signature.asc
Description: This is a digitally signed message part
