On 21/03/18 16:18, Roger Pau Monné wrote: > On Mon, Mar 19, 2018 at 07:13:41PM +0000, Andrew Cooper wrote: >> xc_config is only used by xc_domain_create(), but by calling >> libxl__arch_domain_{prepare,save}_config() we clobber the real settings with >> the default settings. >> >> Move all data and calls relating to xc_domain_create() into the path which >> calls it. >> >> As far as I can tell, soft_reset has always been broken for ARM domains using >> LIBXL_GIC_VERSION_DEFAULT, which elicits a hard error out of >> libxl__arch_domain_save_config(). >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Roger Pau Monné <roger....@citrix.com> > > AFAICT this didn't affect x86 because libxl__arch_domain_save_config > is a noop?
Correct. I've tweaked the commit message to include this. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel