> On 19. Mar 2018, at 19:13, Andrew Cooper <andrew.coop...@citrix.com> wrote:
>
> + max_grant_frames: int32;
> + max_maptrack_frames: int32;
As part of:
> +type domctl_create_config =
> +{
> + ssidref: int32;
> + handle: string;
> + flags: domain_create_flag list;
> + max_vcpus: int32;
> + max_evtchn_port: int32;
> + max_grant_frames: int32;
> + max_maptrack_frames: int32;
> + arch: arch_domainconfig;
> +}
This is a minor point: in OCaml, values of type int32 and int64 are represented
as pointers to a memory block containing the value. This is unlike an int,
which is represented simply as part of a memory block that represents the
record value. Because OCaml uses one bit as a tag, the range of int and int32
(on a 32-bit system) is different. Most of the time the range is large enough
and people use int rather than int32 or int64 for that reason. I would expect
that an int is large enough, especially on a 64-bit system. However, if int32
makes it easier to align this with the C code, this is fine, especially because
there are not many values of omctl_create_config to be expected.
— Christian
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
