On 18.08.2021 22:29, Bobby Eshleman wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -36,6 +36,7 @@ > #include <asm/processor.h> > #include <asm/amd.h> > #include <asm/debugreg.h> > +#include <asm/domain.h> > #include <asm/msr.h> > #include <asm/i387.h> > #include <asm/iocap.h> > @@ -58,7 +59,6 @@ > #include <asm/hvm/trace.h> > #include <asm/hap.h> > #include <asm/apic.h> > -#include <asm/debugger.h> > #include <asm/hvm/monitor.h> > #include <asm/monitor.h> > #include <asm/xstate.h>
While it's generally a good idea to explicitly #include headers that a source file depends upon, I'm not convinced in this case: sched.h includes xen/domain.h, which in turn includes asm/domain.h. And this dependency chain is very unlikely to go away, as sched.h needs to see full struct domain and struct vcpu, all of which come from */domain.h. Jan
