On 18/08/2021 21:29, Bobby Eshleman wrote: > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > index fe38cfd544..ef8c2c4770 100644 > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -20,7 +20,7 @@ obj-y += cpuid.o > obj-$(CONFIG_PV) += compat.o > obj-$(CONFIG_PV32) += x86_64/compat.o > obj-$(CONFIG_KEXEC) += crash.o > -obj-$(CONFIG_GDBSX) += debug.o > +obj-$(CONFIG_GDBSX) += gdbsx.o
This wants moving now to retain alphabetical order. > diff --git a/xen/include/asm-x86/gdbsx.h b/xen/include/asm-x86/gdbsx.h > new file mode 100644 > index 0000000000..2b8812881d > --- /dev/null > +++ b/xen/include/asm-x86/gdbsx.h > @@ -0,0 +1,17 @@ > +#ifndef __X86_GDBX_H > +#define __X86_GDBX_H__ Broken header guard. > + > +#ifdef CONFIG_GDBSX > + > +int gdbsx_guest_mem_io(domid_t domid, struct xen_domctl_gdbsx_memio *iop); > + > +#else > + Need to include <xen/errno.h> to avoid breaking the !GDBSX build. Can fix all on commit. ~Andrew
