Hello Oleksandr,
On 24/11/16 12:53, Oleksandr Andrushchenko wrote:
Any people who wants to use the PV driver for other OS than Linux will have
to do it. So, may I ask why don't you write a platform agnostic header?
This would also make easier to share the PV driver code between different
OS.
There are 2 files: sndif.h which is platform agnostic and sndif_linux.h
I don't consider sndif.h been agnostic. It is just a bunch of array
definition. Each OS would have to implement their own headers in order
to easily access command fields.
which is Linux platform specific (this is exactly the file which every platform
will need to define, e.g. sndif_windows.h).
In my case I need it to at least define Linux specific __packed
attribute which is not supported by Win AFAIK.
All the other PV protocols are able to define structure that are
platform agnostic. I would like to understand why you cannot do this here.
Not mentioning that using __packed is usually a bad idea because it can
mess-up with the natural alignment of the fields and makes the
programmer's life more miserable (see an example in drm PV drivers).
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
