>>> On 11.08.16 at 16:12, <jbeul...@suse.com> wrote: >>>> On 06.08.16 at 01:04, <daniel.ki...@oracle.com> wrote: >> --- a/xen/arch/x86/boot/reloc.c >> +++ b/xen/arch/x86/boot/reloc.c >> @@ -32,60 +32,69 @@ typedef unsigned int u32; >> >> static u32 alloc; >> >> -static void *reloc_mbi_struct(void *old, unsigned int bytes) >> +static u32 alloc_mem(u32 bytes) > > Conversion of alloc to be of pointer type (in the earlier patch), and > then making the return type here and ... > >> +static u32 copy_mem(u32 src, u32 bytes) > > ... all of the types here follow suit would apparently be quite > beneficial to the number of casts needed.
Or maybe, considering patch 8, in a slight variation thereof: Do the conversion as suggested, but have a helper wrapper of the type above, taking care of all the casting. That way both the actual implementation and the callers can stay (mostly) cast free. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
