On 06/08/16 00:04, Daniel Kiper wrote: > Its visibility is not needed and just pollute symbol table. > > Suggested-by: Jan Beulich <jbeul...@suse.com> > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > --- > xen/arch/x86/boot/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 85770e8..e34351c 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -32,7 +32,7 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER ****/ > .long MULTIBOOT_HEADER_FLAGS > /* Checksum: must be the negated sum of the first two fields. */ > .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) > -multiboot1_header_end: > +.Lmultiboot1_header_end:
I put this in as a non local symbol for a very good reason, and see no justification to change it. It is very important to be able to distinguish data from opcode in the disassembly, and one extra global symbol will not break the bank. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
