On June 14, 2016 5:03 PM, Jan Beulich <jbeul...@suse.com> wrote:
> - if ( amd_iommu_update_ivrs_mapping_acpi() != 0 )
> + rc = amd_iommu_update_ivrs_mapping_acpi();
> + if ( rc )
> goto error_out;
>
> /* initialize io-apic interrupt remapping entries */
> - if ( iommu_intremap && amd_iommu_setup_ioapic_remapping() != 0 )
> + if ( iommu_intremap )
> + rc = amd_iommu_setup_ioapic_remapping();
> + if ( rc )
> goto error_out;
Is it better to indent this if() here? Then,
+ if ( iommu_intremap )
+ {
+ rc = amd_iommu_setup_ioapic_remapping();
+ if ( rc )
+ goto error_out;
+ }
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
