On Wed, Apr 27, 2016 at 11:57 PM, Razvan Cojocaru <rcojoc...@bitdefender.com > wrote:
> On 04/27/16 23:33, Tamas K Lengyel wrote: > > Since in-guest debug exceptions are now unconditionally trapped to Xen, > adding > > a hook for vm_event subscribers to tap into this new always-on guest > event. We > > rename along the way hvm_event_breakpoint_type to hvm_event_type to > better > > match the various events that can be passed with it. We also introduce > the > > necessary monitor_op domctl's to enable subscribing to the events. > > The monitor / event code looks fine, but I'm not sure about > hvm_event_type / hvm_monitor_event(). Presumably even a CR3 write event > coming from a HVM guest is an event, and HVM-related, hence a hvm_event > - i.e. the generic nature of the name is a bit confusing to me. Maybe > not so to other reviewers? > Yea, I'm not too happy with the naming in general for hvm/event, it all should be renamed to be clear that it's part of the monitor subsystem. I think I'll turn this into a 2-patch series, where I rename the existing stuff from hvm/event to hvm/monitor then change the name of this function from hvm_monitor_breakpoint to hvm_monitor_debug. Tamas
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
