On 04/27/16 23:33, Tamas K Lengyel wrote: > Since in-guest debug exceptions are now unconditionally trapped to Xen, adding > a hook for vm_event subscribers to tap into this new always-on guest event. We > rename along the way hvm_event_breakpoint_type to hvm_event_type to better > match the various events that can be passed with it. We also introduce the > necessary monitor_op domctl's to enable subscribing to the events.
The monitor / event code looks fine, but I'm not sure about hvm_event_type / hvm_monitor_event(). Presumably even a CR3 write event coming from a HVM guest is an event, and HVM-related, hence a hvm_event - i.e. the generic nature of the name is a bit confusing to me. Maybe not so to other reviewers? Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
