>>> Konrad Rzeszutek Wilk <kon...@kernel.org> 04/06/16 10:05 PM >>> >> > --- a/xen/include/xen/version.h >> > +++ b/xen/include/xen/version.h >> > @@ -17,4 +17,7 @@ const char *xen_deny(void); >> > #include <xen/types.h> >> > int xen_build_id(const void **p, unsigned int *len); >> > >> > +#include <xen/elfstructs.h> >> > +int xen_build_id_check(const Elf_Note *n, const void **p, unsigned int >> > *len); >> >> The #include is misplaced again, and I'm rather hesitant to see >> version.h gain this dependency. Couldn't this go into xen/elf.h? > >Sadly no. If I remove these two includes (xen/types.h and >xen/elfstructs.h) the compile breaks. It breaks for kernel.c, console,c, >setup.c and so on - complaining about unknown type name 'Elf_Note'.
I guess there's a misunderstanding of my use of "this" here: I meant the function declaration to get moved over. I can't see how that would cause compilation problems. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
