On 03/05/2016 12:42 AM, Ian Jackson wrote:
Changlong Xie writes ("[PATCH v11 04/27] tools/libxl: Introduce new helper function
dup_fd_helper()"):
From: Wen Congyang <we...@cn.fujitsu.com>
It is pure refactoring and no functional changes.
...
/*----- helper execution -----*/
+static int dup_fd_helper(libxl__gc *gc, int fd, const char *what)
+{
This is a fine thing to do. But the function name is less than
informative. I think I would call it something like `dup_cloexec'.
ok
The use of the term `helper' here is particularly confusing because it
also refers to the `save helper' of which this is part.
And
- missing newline after the /*---*/ comment
- this function should have a doc comment saying it cannot fail
ok, will fix in next version.
Thanks
-Xie
Ian.
.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
