Changlong Xie writes ("[PATCH v11 19/27] COLO: introduce new API to
prepare/start/do/get_error/stop replication"):
> From: Wen Congyang <[email protected]>
>
> We will use qemu block replication, and qemu provides some qmp commands
> to prepare replication, start replication, get replication error, and
> stop replication. Introduce new API to execute these qmp commands.
How will this work if in future we want to support HVM (or
hvm-lite-ng) guests ?
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 5160939..8cb9f19 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1771,6 +1771,26 @@ _hidden int
> libxl__qmp_set_global_dirty_log(libxl__gc ...
> +_hidden int libxl__qmp_nbd_server_add(libxl__gc *gc, int domid, const char
> *disk);
It's a tiny nit, but can I grumble about the long lines here ? Less
than ~70-75 characters is best.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel