On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote:
> Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com>
>
I don't recall if I said this already, but main_sharing() does not
belong here.
> @@ -5095,11 +5095,11 @@ int main_create(int argc, char **argv)
> rc = create_domain(&dom_info);
> if (rc < 0) {
> free(dom_info.extra_config);
> - return -rc;
> + return EXIT_FAILURE;
> }
As far as I can see, create_domain() mostly returns libxl error codes.
I think you should convert that one as well (in 0/-1, as it's internal,
and doing it in this patch would be ok).The rest of the patch looks ok to me. Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
