On Wed, 2016-02-24 at 14:55 +0100, Olaf Hering wrote: > On Wed, Feb 24, Harmandeep Kaur wrote: > > > - exit(2); > > + exit(EXIT_FAILURE); > > The commit message should state why changing the value is fine. > I dont know if anyone actually cares about the exact value. > This has been discussed before here on the mailing list, and there already are patches committed that do this same thing in a bunch of cases (and, of course, the aim is consistently doing it everywhere).
Previous discussion is here: http://lists.xen.org/archives/html/xen-devel/2015-10/msg02497.html http://lists.xen.org/archives/html/xen-devel/2015-10/msg02501.html http://lists.xen.org/archives/html/xen-devel/2015-10/msg02509.html And, even before, here: http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01336.html http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01341.html I'm quit sure there is no one doing anything useful with exit codes right now, as they're so inconsistent that it would just be plain impossible! :-) Anyway, Harmandeep, can you summarize better (and maybe reference) these previous discussions and your previous related work in the cover letter of this series (and any other similar one that may follow)? Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
